test(e2e): L5 hard-nav instant shell for marketing routes - #177
Open
mkayander wants to merge 2 commits into
Open
test(e2e): L5 hard-nav instant shell for marketing routes#177mkayander wants to merge 2 commits into
mkayander wants to merge 2 commits into
Conversation
Add instant-marketing-hard-nav spec using @next/playwright instant() on MPA reload. Tests auto-skip under next dev (instant MPA CSR-bails) and run on production/preview PPR shells. Update L5 docs with follow-ups.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
mkayander
marked this pull request as ready for review
August 31, 2026 20:21
- Add hasProductionInstantShell helper: detect dev CSR bailout and require SSR <h1> instead of i18n string in RSC payload (avoids false positives) - Fix clickAppBarHomeLink: target last visible banner link and DOM-click to avoid MUI Typography pointer interception (fixes CI flake on Pyodide test) - Deduplicate instant-marketing-nav home navigation via shared helper - Docs: remove stale DocumentLocaleSync references; cite RootHtmlShell
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
L5 follow-up to #176: e2e coverage for hard navigation (MPA reload) instant shell on default-locale marketing routes (
/,/privacy,/daily).Changes
e2e/instant-marketing-hard-nav.spec.ts— uses@next/playwrightinstant()onpage.reload()for three marketing routese2e/helpers/instantNavigationShell.ts— production shell probe that:next devinstant MPA CSR bailout (BAILOUT_TO_CLIENT_SIDE_RENDERING,/_errorshell)<h1>with expected copy (not i18n string embedded only in RSC payload)e2e/helpers/playgroundMonacoEditor.ts— hardensclickAppBarHomeLinkfor Activity/cacheComponents DOM (last visible banner link + DOM click to avoid MUI Typography pointer interception)DocumentLocaleSyncreferencesTesting
pnpm lint/pnpm test:ci— passNotes
getServerSession/headers()broke marketing prerender.